content/public/browser/push_messaging_service.h - Issue 914693002: Push API: Fix unsubscribing from GCM on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/push_messaging_service.h

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter & jianli's review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/push_messaging_service.h

diff --git a/content/public/browser/push_messaging_service.h b/content/public/browser/push_messaging_service.h

index 4d06cdde2c1ea99adff2acc7adc2f7a3fbcbf60e..6ad9e70b7c88a4723c3f0688e82f8ec3e05b7500 100644

--- a/content/public/browser/push_messaging_service.h

+++ b/content/public/browser/push_messaging_service.h

@@ -77,6 +77,7 @@ class CONTENT_EXPORT PushMessagingService {

// the push service.

virtual void Unregister(const GURL& requesting_origin,

int64 service_worker_registration_id,

+ const std::string& sender_id,

bool retry_on_failure,

const UnregisterCallback& callback) = 0;