chrome/browser/services/gcm/push_messaging_service_impl.h - Issue 914693002: Push API: Fix unsubscribing from GCM on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.h

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter & jianli's review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/services/gcm/push_messaging_service_impl.h

diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h

index 29c03b899b7421923248f83cf776b76af8278f50..f4c2e8eb1c40040ba6a36c4e1aec0266fb3d1883 100644

--- a/chrome/browser/services/gcm/push_messaging_service_impl.h

+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h

@@ -67,6 +67,7 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

void Unregister(

const GURL& requesting_origin,

int64 service_worker_registration_id,

+ const std::string& sender_id,

bool retry_on_failure,

const content::PushMessagingService::UnregisterCallback&) override;

blink::WebPushPermissionStatus GetPermissionStatus(

@@ -119,6 +120,7 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

bool allow);

void Unregister(const std::string& app_id_guid,

+ const std::string& sender_id,

bool retry_on_failure,

const content::PushMessagingService::UnregisterCallback&);