Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/services/gcm/push_messaging_browsertest.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address peter & jianli's review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/push_messaging_browsertest.cc
diff --git a/chrome/browser/services/gcm/push_messaging_browsertest.cc b/chrome/browser/services/gcm/push_messaging_browsertest.cc
index d9432ab9549a85b902feb277697ab5a87e1a017b..243df3e96e32fca6780ec2f043cd483384e92889 100644
--- a/chrome/browser/services/gcm/push_messaging_browsertest.cc
+++ b/chrome/browser/services/gcm/push_messaging_browsertest.cc
@@ -423,6 +423,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventSuccess) {
ASSERT_EQ("true - is controlled", script_result);
GCMClient::IncomingMessage message;
+ message.sender_id = "1234567890";
message.data["data"] = "testdata";
push_service()->OnMessage(app_id.app_id_guid(), message);
ASSERT_TRUE(RunScript("resultQueue.pop()", &script_result));
@@ -457,6 +458,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventNoServiceWorker) {
base::Unretained(&callback)));
GCMClient::IncomingMessage message;
+ message.sender_id = "1234567890";
message.data["data"] = "testdata";
push_service()->OnMessage(app_id.app_id_guid(), message);
@@ -496,6 +498,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PushEventNoPermission) {
base::Unretained(&callback)));
GCMClient::IncomingMessage message;
+ message.sender_id = "1234567890";
message.data["data"] = "testdata";
push_service()->OnMessage(app_id.app_id_guid(), message);
@@ -537,6 +540,7 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
// If the site is visible in an active tab, we should not force a notification
// to be shown. Try it twice, since we allow one mistake per 10 push events.
GCMClient::IncomingMessage message;
+ message.sender_id = "1234567890";
for (int n = 0; n < 2; n++) {
message.data["data"] = "testdata";
push_service()->OnMessage(app_id.app_id_guid(), message);

Powered by Google App Engine
This is Rietveld 408576698