Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2725)

Unified Diff: chrome/browser/services/gcm/fake_gcm_profile_service.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/fake_gcm_profile_service.cc
diff --git a/chrome/browser/services/gcm/fake_gcm_profile_service.cc b/chrome/browser/services/gcm/fake_gcm_profile_service.cc
index 3d2d2109cdfbe5eb0858b789bccd4fbc4c3e5837..1c28470dc374706a3b1143f351b3e84a9c070c0e 100644
--- a/chrome/browser/services/gcm/fake_gcm_profile_service.cc
+++ b/chrome/browser/services/gcm/fake_gcm_profile_service.cc
@@ -37,7 +37,8 @@ class CustomFakeGCMDriver : public FakeGCMDriver {
// FakeGCMDriver overrides:
void RegisterImpl(const std::string& app_id,
const std::vector<std::string>& sender_ids) override;
- void UnregisterImpl(const std::string& app_id) override;
+ void UnregisterImpl(const std::string& app_id,
+ const std::string* maybe_sender_id) override;
void SendImpl(const std::string& app_id,
const std::string& receiver_id,
const GCMClient::OutgoingMessage& message) override;
@@ -66,7 +67,9 @@ void CustomFakeGCMDriver::RegisterImpl(
sender_ids));
}
-void CustomFakeGCMDriver::UnregisterImpl(const std::string& app_id) {
+void CustomFakeGCMDriver::UnregisterImpl(
+ const std::string& app_id,
+ const std::string* /* maybe_sender_id */) {
Peter Beverloo 2015/02/17 18:49:36 nit: we don't warn on unused arguments, please jus
johnme 2015/02/17 21:24:07 Removed.
base::MessageLoop::current()->PostTask(
FROM_HERE, base::Bind(
&FakeGCMProfileService::UnregisterFinished,
« no previous file with comments | « no previous file | chrome/browser/services/gcm/push_messaging_browsertest.cc » ('j') | components/gcm_driver/gcm_driver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698