Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7984)

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_gcm_app_handler.cc
diff --git a/chrome/browser/extensions/extension_gcm_app_handler.cc b/chrome/browser/extensions/extension_gcm_app_handler.cc
index 92cec5e6db5ecfd81d1ca91e911fe3d05bb662cb..258cfd97eaaeb27655f72b07bcdf1ee8fee08776 100644
--- a/chrome/browser/extensions/extension_gcm_app_handler.cc
+++ b/chrome/browser/extensions/extension_gcm_app_handler.cc
@@ -132,12 +132,18 @@ void ExtensionGCMAppHandler::OnExtensionUninstalled(
const Extension* extension,
extensions::UninstallReason reason) {
if (IsGCMPermissionEnabled(extension)) {
+#if defined(OS_ANDROID)
+ LOG(FATAL) << "Unregistering from GCM requires a sender_id on Android";
+#else
+ std::vector<std::string> sender_ids; // These are ignored on desktop.
GetGCMDriver()->Unregister(
extension->id(),
+ sender_ids,
base::Bind(&ExtensionGCMAppHandler::OnUnregisterCompleted,
weak_factory_.GetWeakPtr(),
extension->id()));
RemoveAppHandler(extension->id());
+#endif
}
}

Powered by Google App Engine
This is Rietveld 408576698