Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 914573004: Discard scrolling to the saved scroll points if there is any selection done by user. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: adding layout test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index b4c9085c4eb5408e8f3114a93cfaefdd90f4f718..e8cf4acb02b48d85041cd769a57d04eacd372734 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -1770,6 +1770,7 @@ void FrameSelection::revealSelection(const ScrollAlignment& alignment, RevealExt
// FIXME: This code only handles scrolling the startContainer's layer, but
// the selection rect could intersect more than just that.
// See <rdar://problem/4799899>.
+ m_frame->view()->setWasScrolledByUser(true);
yoichio 2015/03/11 04:16:52 Could you confirm this code path is called by only
pals 2015/03/11 06:09:28 I am not sure about this, I am not very familiar a
if (start.deprecatedNode()->renderer()->scrollRectToVisible(rect, alignment, alignment))
updateAppearance();
}

Powered by Google App Engine
This is Rietveld 408576698