media/audio/audio_unittest_utils.h - Issue 914483002: Add flag --require-audio-hardware-for-testing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/audio/audio_unittest_utils.h

Issue 914483002: Add flag --require-audio-hardware-for-testing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« media/audio/audio_input_volume_unittest.cc ('K') | « media/audio/audio_manager_unittest.cc ('k') | media/audio/mac/audio_auhal_mac_unittest.cc » ('j') | media/audio/win/audio_output_win_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 #include "base/command_line.h"

	2 #include "base/logging.h"

	3 #include "media/base/media_switches.h"

	4 #include "testing/gtest/include/gtest/gtest.h"

	5

	6 // Use in tests to either skip or fail a test when the system is missing a

	7 // required audio device or library. If the \|kRequireAudioHardwareForTesting\|

	8 // flag is set, missing requirements will cause the test to fail. Otherwise it

	9 // will be skipped.

	10 #define CAN_RUN_AUDIO_TEST_IF(requirements_satisfied) \
	DaleCurtis 2015/02/09 21:21:31 Hmm, naming feels odd. What about something like: Hmm, naming feels odd. What about something like: ABORT_AUDIO_TEST_IF_NOT(...) Both paths are abort, just some are hard vs soft failures, right? watk 2015/02/09 22:03:57 Much better, thanks Show quoted text On 2015/02/09 21:21:31, DaleCurtis wrote: > Hmm, naming feels odd. What about something like: > > ABORT_AUDIO_TEST_IF_NOT(...) > > Both paths are abort, just some are hard vs soft failures, right? Much better, thanks
	11 do { \

	12 bool satisfied = requirements_satisfied; \
	DaleCurtis 2015/02/09 21:21:31 Most of this should be moved into a static functio Most of this should be moved into a static function and only the FAIL() or return part kept in the macro. watk 2015/02/09 22:03:57 Done. Show quoted text On 2015/02/09 21:21:31, DaleCurtis wrote: > Most of this should be moved into a static function and only the FAIL() or > return part kept in the macro. Done.
	13 bool fail_if_unsatisfied = \

	14 base::CommandLine::ForCurrentProcess()->HasSwitch( \

	15 switches::kRequireAudioHardwareForTesting); \

	16 const char* message = \

	17 "Requirement(s) not satisfied (" #requirements_satisfied ")"; \

	18 if (fail_if_unsatisfied && !satisfied) { \

	19 FAIL() << message; \

	20 } \

	21 if (!satisfied) { \

	22 LOG(WARNING) << "Skipping test: " << message; \

	23 return; \

	24 } \

	25 } while (false)

OLD	NEW