Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 914403004: X87: new classes: implement default constructors (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: new classes: implement default constructors port 9b158fa79a510bd1fee2f663163d9116879cb33a (r26594) original commit message: new classes: implement default constructors BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/fb55eae323e69e6382efb7afda3301776a4206fd Cr-Commit-Position: refs/heads/master@{#26601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M src/x87/full-codegen-x87.cc View 4 chunks +52 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-12 03:48:24 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-12 03:50:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914403004/1
5 years, 10 months ago (2015-02-12 03:51:56 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb55eae323e69e6382efb7afda3301776a4206fd Cr-Commit-Position: refs/heads/master@{#26601}
5 years, 10 months ago (2015-02-12 03:52:27 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-12 03:52:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb55eae323e69e6382efb7afda3301776a4206fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698