Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: ui/file_manager/file_manager/foreground/js/import_controller_unittest.js

Issue 914353004: Update import details panel to comply (mostly) with UX direction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Exclude details panel button from tab index. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/import_controller_unittest.js
diff --git a/ui/file_manager/file_manager/foreground/js/import_controller_unittest.js b/ui/file_manager/file_manager/foreground/js/import_controller_unittest.js
index b7d716497a9543d2795a823a4db526543885fa08..015d778b1d4789a9ab3176cd83b53d4534a35183 100644
--- a/ui/file_manager/file_manager/foreground/js/import_controller_unittest.js
+++ b/ui/file_manager/file_manager/foreground/js/import_controller_unittest.js
@@ -483,6 +483,9 @@ importer.TestCommandWidget = function() {
/** @public {function()} */
this.executeListener;
+ /** @public {function()} */
+ this.destinationListener;
+
/** @private {!importer.Resolver.<!importer.CommandUpdate>} */
this.updateResolver_ = new importer.Resolver();
@@ -503,6 +506,12 @@ importer.TestCommandWidget.prototype.addImportClickedListener =
};
/** @override */
+importer.TestCommandWidget.prototype.addDestinationClickedListener =
+ function(listener) {
+ this.destinationListener = listener;
+};
+
+/** @override */
importer.TestCommandWidget.prototype.update = function(update) {
assertFalse(this.updateResolver_.settled, 'Should not have been settled.');
this.updateResolver_.resolve(update);
@@ -514,11 +523,6 @@ importer.TestCommandWidget.prototype.updateDetails = function(scan) {
};
/** @override */
-importer.TestCommandWidget.prototype.resetDetails = function() {
- // TODO(smckay)
-};
-
-/** @override */
importer.TestCommandWidget.prototype.setDetailsVisible = function(visible) {
// TODO(smckay)
};

Powered by Google App Engine
This is Rietveld 408576698