Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 914333002: disable some harmony scoping tests (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

disable some harmony scoping tests R=verwaest@chromium.org BUG=v8:3914 LOG=N Committed: https://crrev.com/102ddf35cfb4df0c2d4593f13f317f99b77dea9e Cr-Commit-Position: refs/heads/master@{#26794}

Patch Set 1 : just disable ics #

Patch Set 2 : cleanup test #

Patch Set 3 : disable failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-decls.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcarney
On 2015/02/11 20:59:30, dcarney wrote: > mailto:dcarney@chromium.org changed reviewers: > + mailto:verwaest@chromium.org ptal, it's a ...
5 years, 10 months ago (2015-02-11 21:02:44 UTC) #2
Toon Verwaest
lgtm @dslomov: fyi.
5 years, 10 months ago (2015-02-23 11:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914333002/40001
5 years, 10 months ago (2015-02-23 11:38:00 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-23 11:58:47 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-23 11:58:51 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 11:59:07 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/102ddf35cfb4df0c2d4593f13f317f99b77dea9e
Cr-Commit-Position: refs/heads/master@{#26794}

Powered by Google App Engine
This is Rietveld 408576698