Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: scripts/tools/runit.py

Issue 914303007: Fix runit.py script on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/tools/runit.py
diff --git a/scripts/tools/runit.py b/scripts/tools/runit.py
index 8180e74b3eb69b0b1536a9739890affdcb81f059..7a3322e05c20a30bbb2c755ea85033c0648ee7cb 100755
--- a/scripts/tools/runit.py
+++ b/scripts/tools/runit.py
@@ -85,6 +85,10 @@ def main():
if options.show_path:
print 'Set PYTHONPATH: %s' % os.environ['PYTHONPATH']
+ # Windows must call python as the subprocess executable.
+ if 'win' in sys.platform.lower():
dnj 2015/02/12 00:55:22 The best way to check for Windows is probably http
David Yen 2015/02/12 17:17:40 Only to be less intrusive, you're right that is is
+ args = [sys.executable] + args
+
# Use subprocess instead of execv because otherwise windows destroys quoting.
p = subprocess.Popen(args)
p.wait()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698