Makefile.standalone - Issue 914263005: Subzero: switch from llvm-objdump to objdump for lit tests (for LLVM merge)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile.standalone

Issue 914263005: Subzero: switch from llvm-objdump to objdump for lit tests (for LLVM merge) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: backup... 9 to go Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Makefile.standalone

diff --git a/Makefile.standalone b/Makefile.standalone

index e298cf0ae33a3d003c815556752d211c131b5fc9..284ebc32e8729ee0f2e0ea999022bb731a031527 100644

--- a/Makefile.standalone

+++ b/Makefile.standalone

@@ -28,6 +28,10 @@ LIBCXX_INSTALL_PATH ?= $(shell readlink -e \

CLANG_PATH ?= $(shell readlink -e \

../../../../third_party/llvm-build/Release+Asserts/bin)

+# The location of binutils tools (e.g., objdump).

+BINUTILS_BIN_PATH ?= $(shell readlink -e \

+ ../../out/binutils_pnacl_x86_64_linux_install/bin)

Karl 2015/02/16 18:50:13 Why is this different than other lines suchas LLVM

jvoung (off chromium) 2015/02/17 22:17:04 Okay making it the work directory too (I originall

HOST_ARCH ?= x86_64

ifeq ($(HOST_ARCH),x86_64)

HOST_FLAGS = -m64 -stdlib=libc++

@@ -80,6 +84,7 @@ $(info Using LLVM_SRC_PATH = $(LLVM_SRC_PATH))

$(info Using LLVM_BIN_PATH = $(LLVM_BIN_PATH))

$(info Using LIBCXX_INSTALL_PATH = $(LIBCXX_INSTALL_PATH))

$(info Using CLANG_PATH = $(CLANG_PATH))

+$(info Using BINUTILS_BIN_PATH = $(BINUTILS_BIN_PATH))

$(info Using HOST_ARCH = $(HOST_ARCH))

$(info -----------------------------------------------)

@@ -188,6 +193,7 @@ $(OBJDIR)/unittest: $(OBJDIR)

check-lit: $(OBJDIR)/llvm2ice make_symlink

LLVM_BIN_PATH=$(LLVM_BIN_PATH) \

+ BINUTILS_BIN_PATH=$(BINUTILS_BIN_PATH) \

$(LLVM_SRC_PATH)/utils/lit/lit.py -sv tests_lit

check-unit: $(OBJDIR)/run_unittests

« no previous file with comments | « no previous file | pydir/run-llvm2ice.py » ('j') | no next file with comments »