Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 914243003: Sort GYP files under chrome sub directories using tools/sort_sources.py (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, wfh+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort GYP files under chrome sub directories using tools/sort_sources.py GYP files directly under chrome were sorted in crrev.com/315927 The patch is to sort smaller GYP files in sub directories. Also fix a bug where rc.version, ico, def, release suffixes weren't handled correctly. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/72c7409fa56a30e34a747a74143025c3e4b5d3ae Cr-Commit-Position: refs/heads/master@{#316127}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_watcher/chrome_watcher.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/installer_tools.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer.gyp View 2 chunks +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/crash_service/caps/caps.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/profile_reset/jtl_compiler.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/sort_sources.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
satorux1
ncbray: chrome/test/data/nacl/nacl_test_data.gyp thestig: everything else
5 years, 10 months ago (2015-02-12 06:49:45 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-12 07:09:20 UTC) #3
Nick Bray (chromium)
LGTM
5 years, 10 months ago (2015-02-12 18:10:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914243003/20001
5 years, 10 months ago (2015-02-13 00:40:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 01:57:12 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 01:57:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72c7409fa56a30e34a747a74143025c3e4b5d3ae
Cr-Commit-Position: refs/heads/master@{#316127}

Powered by Google App Engine
This is Rietveld 408576698