Source/modules/accessibility/AXTableCell.cpp - Issue 914233002: Use effective columns when cells with colspan are present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXTableCell.cpp

Issue 914233002: Use effective columns when cells with colspan are present. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Just updating expectation result Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/table-cells-with-colspan-expected.txt ('k') | Source/modules/accessibility/AXTableColumn.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXTableCell.cpp

diff --git a/Source/modules/accessibility/AXTableCell.cpp b/Source/modules/accessibility/AXTableCell.cpp

index 948dde3fba5dc3e782a00ff61a463a90909f9e05..790164c0aca2b9b5e6f6d5c15779ab5d4f333dbb 100644

--- a/Source/modules/accessibility/AXTableCell.cpp

+++ b/Source/modules/accessibility/AXTableCell.cpp

@@ -196,8 +196,8 @@ void AXTableCell::columnIndexRange(pair<unsigned, unsigned>& columnRange)

return;

LayoutTableCell* cell = toLayoutTableCell(m_renderer);

- columnRange.first = cell->col();

- columnRange.second = cell->colSpan();

+ columnRange.first = cell->table()->colToEffCol(cell->col());

dmazzoni 2015/02/13 07:07:34 Do we need to null-check any of these? Please loo

+ columnRange.second = cell->table()->colToEffCol(cell->col() + cell->colSpan()) - columnRange.first;

}

SortDirection AXTableCell::sortDirection() const

« no previous file with comments | « LayoutTests/accessibility/table-cells-with-colspan-expected.txt ('k') | Source/modules/accessibility/AXTableColumn.cpp » ('j') | no next file with comments »