Issue 914213002: Appease clang Chromium-style / fix a build error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 914213002: Appease clang Chromium-style / fix a build error. (Closed)

Created:
5 years, 10 months ago by ppi

Modified:
5 years, 10 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Appease clang Chromium-style / fix a build error. This fixes the build error on bots: services/http_server/http_server_impl.h:55:3: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7257da6f43b9bd623b89912192e327a23d2623be

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	services/http_server/http_server_impl.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	services/http_server/http_server_impl.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

ppi

5 years, 10 months ago (2015-02-11 16:03:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
7257da6f43b9bd623b89912192e327a23d2623be (presubmit successful).