Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 914183002: Remove window.chrome.gpuBenchmarking.beginWindowSnapshotPNG (Closed)

Created:
5 years, 10 months ago by vkuzkokov
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove window.chrome.gpuBenchmarking.beginWindowSnapshotPNG Extracted part 3 of https://codereview.chromium.org/190693002/ BUG=242405 Committed: https://crrev.com/82df040494f900cb3622a8f51d43dac3b075cdfc Cr-Commit-Position: refs/heads/master@{#320910}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -193 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 3 chunks +0 lines, -60 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_latency_tracker.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/common/view_messages.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 3 chunks +0 lines, -62 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 4 chunks +0 lines, -34 lines 0 comments Download
M ui/events/latency_info.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/latency_info.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
vkuzkokov
5 years, 10 months ago (2015-02-16 17:21:39 UTC) #4
vkuzkokov
jam: content/browser/renderer_host/render_widget_host_impl.h content/browser/renderer_host/render_widget_host_impl.cc content/browser/renderer_host/render_widget_host_latency_tracker.cc content/renderer/gpu/gpu_benchmarking_extension.h content/renderer/gpu/gpu_benchmarking_extension.cc content/renderer/render_view_impl.h content/renderer/render_view_impl.cc tsepez: content/common/view_messages.h jbauman: ui/events/latency_info.h ui/events/latency_info.cc
5 years, 10 months ago (2015-02-17 12:45:01 UTC) #6
jam
lgtm
5 years, 10 months ago (2015-02-17 16:47:25 UTC) #7
Tom Sepez
RS LGTM on deleting messages.
5 years, 10 months ago (2015-02-17 19:08:10 UTC) #8
vkuzkokov
jbauman, ping on ui/ changes.
5 years, 9 months ago (2015-03-06 16:41:57 UTC) #9
vkuzkokov
On 2015/03/06 16:41:57, vkuzkokov wrote: > jbauman, ping on ui/ changes. jbauman, ping again on ...
5 years, 9 months ago (2015-03-13 14:34:58 UTC) #11
Yufeng Shen (Slow to review)
On 2015/03/13 14:34:58, vkuzkokov wrote: > On 2015/03/06 16:41:57, vkuzkokov wrote: > > jbauman, ping ...
5 years, 9 months ago (2015-03-13 14:53:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914183002/60001
5 years, 9 months ago (2015-03-17 12:49:42 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 9 months ago (2015-03-17 13:46:21 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 13:47:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82df040494f900cb3622a8f51d43dac3b075cdfc
Cr-Commit-Position: refs/heads/master@{#320910}

Powered by Google App Engine
This is Rietveld 408576698