Fix AudioPump to pause the stream when the network is congested.

Fix AudioPump to pause the stream when the network is congested.

Previously AudioPump would buffer infinite amount of audio data even
when the network is congested. With this changed the amount of data
it can buffer is limited to 5kB and it starts dropping packets after
that.

Committed: https://crrev.com/22931b53164771ea916a2d0498073198f2567a09
Cr-Commit-Position: refs/heads/master@{#316669}

[Sergey Ulanov, 2015-02-11 23:16:08]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2015-02-11 23:16:20]

sergeyu@chromium.org changed reviewers:
+ wez@chromium.org

[Wez, 2015-02-12 02:29:47]

lgtm

https://codereview.chromium.org/914133003/diff/20001/remoting/host/audio_pump.cc
File remoting/host/audio_pump.cc (right):

https://codereview.chromium.org/914133003/diff/20001/remoting/host/audio_pump...
remoting/host/audio_pump.cc:20: // dropping packets. 5kB is about 0.25s in a
stream with 160kb/s bitrate.
Do we run our stream at a fixed bit-rate? If not then why is 160kb/s so special?
:)

Should we express this constant as a number-of-milliseconds and derived the
actual buffer size from that and the bit-rate (or a "usual" bit-rate value)?

[Sergey Ulanov, 2015-02-13 20:59:31]

New patchsets have been uploaded after l-g-t-m from wez@chromium.org

[Sergey Ulanov, 2015-02-13 21:21:56]

https://codereview.chromium.org/914133003/diff/20001/remoting/host/audio_pump.cc
File remoting/host/audio_pump.cc (right):

https://codereview.chromium.org/914133003/diff/20001/remoting/host/audio_pump...
remoting/host/audio_pump.cc:20: // dropping packets. 5kB is about 0.25s in a
stream with 160kb/s bitrate.
On 2015/02/12 02:29:47, Wez wrote:
> Do we run our stream at a fixed bit-rate? If not then why is 160kb/s so
special?
> :)
> 
> Should we express this constant as a number-of-milliseconds and derived the
> actual buffer size from that and the bit-rate (or a "usual" bit-rate value)?

Our opus encoder uses this bitrate. See
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/codec/aud...
.
Added GetBitrate() in AudioEncoder interface.

[Sergey Ulanov, 2015-02-13 21:25:16]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-02-13 21:25:20]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2015-02-13 21:26:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914133003/80001

[commit-bot: I haz the power, 2015-02-13 22:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-13 22:28:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-02-13 22:29:58]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-02-13 22:31:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914133003/80001

[commit-bot: I haz the power, 2015-02-13 23:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-13 23:27:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-02-17 18:16:15]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-02-17 18:17:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914133003/80001

[commit-bot: I haz the power, 2015-02-17 19:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-17 19:55:04]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-02-17 21:04:27]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-02-17 21:05:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914133003/100001

[commit-bot: I haz the power, 2015-02-17 22:16:29]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-02-17 22:17:08]

Patchset 4 (id:??) landed as
https://crrev.com/22931b53164771ea916a2d0498073198f2567a09
Cr-Commit-Position: refs/heads/master@{#316669}

[Sergey Ulanov, 2015-02-17 23:34:37]

Patchset #5 (id:120001) has been deleted