Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: tools/perf/measurements/v8_gc_times.py

Issue 914083005: [Telemetry] Fix 'important' field of certain Values being non-boolean (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits + make bots happy Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/value/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/v8_gc_times.py
diff --git a/tools/perf/measurements/v8_gc_times.py b/tools/perf/measurements/v8_gc_times.py
index 330939494d30bcbda7ce997d5dac28541728d852..9dc8b6f0bd6a0c902b00819464fd730302ad62c4 100644
--- a/tools/perf/measurements/v8_gc_times.py
+++ b/tools/perf/measurements/v8_gc_times.py
@@ -96,23 +96,24 @@ class V8GCTimes(page_test.PageTest):
results.AddValue(scalar.ScalarValue(
results.current_page, v8_event_stat.result_name, 'ms',
v8_event_stat.thread_duration,
- ('Total thread duration spent in %s' %
- v8_event_stat.result_description)))
+ description=('Total thread duration spent in %s' %
+ v8_event_stat.result_description)))
results.AddValue(scalar.ScalarValue(results.current_page,
'%s_outside_idle' % v8_event_stat.result_name, 'ms',
v8_event_stat.thread_duration_outside_idle,
- ('Total thread duration spent in %s outside of idle tasks' %
- v8_event_stat.result_description)))
+ description=(
+ 'Total thread duration spent in %s outside of idle tasks' %
+ v8_event_stat.result_description)))
results.AddValue(scalar.ScalarValue(results.current_page,
'%s_idle_deadline_overrun' % v8_event_stat.result_name, 'ms',
v8_event_stat.idle_task_overrun_duration,
- ('Total idle task deadline overrun for %s idle tasks'
- % v8_event_stat.result_description)))
+ description=('Total idle task deadline overrun for %s idle tasks'
+ % v8_event_stat.result_description)))
results.AddValue(scalar.ScalarValue(results.current_page,
'%s_percentage_idle' % v8_event_stat.result_name, 'idle%',
v8_event_stat.percentage_thread_duration_during_idle,
- ('Percentage of %s spent in idle time' %
- v8_event_stat.result_description)))
+ description=('Percentage of %s spent in idle time' %
+ v8_event_stat.result_description)))
# Add total metrics.
gc_total = sum(x.thread_duration for x in self._v8_event_stats)
@@ -125,20 +126,23 @@ class V8GCTimes(page_test.PageTest):
results.AddValue(scalar.ScalarValue(results.current_page,
'v8_gc_total', 'ms', gc_total,
- 'Total thread duration of all garbage collection events'))
+ description='Total thread duration of all garbage collection events'))
results.AddValue(scalar.ScalarValue(results.current_page,
'v8_gc_total_outside_idle', 'ms', gc_total_outside_idle,
- 'Total thread duration of all garbage collection events outside of '
- 'idle tasks'))
+ description=(
+ 'Total thread duration of all garbage collection events outside of '
+ 'idle tasks')))
results.AddValue(scalar.ScalarValue(results.current_page,
'v8_gc_total_idle_deadline_overrun', 'ms',
gc_total_idle_deadline_overrun,
- 'Total idle task deadline overrun for all idle tasks garbage '
- 'collection events'))
+ description=(
+ 'Total idle task deadline overrun for all idle tasks garbage '
+ 'collection events')))
results.AddValue(scalar.ScalarValue(results.current_page,
'v8_gc_total_percentage_idle', 'idle%', gc_total_percentage_idle,
- 'Percentage of the thread duration of all garbage collection events '
- 'spent inside of idle tasks'))
+ description=(
+ 'Percentage of the thread duration of all garbage collection '
+ 'events spent inside of idle tasks')))
def _AddCpuTimeStatsToResults(self, thread, results):
if thread.toplevel_slices:
« no previous file with comments | « no previous file | tools/telemetry/telemetry/value/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698