Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 914083004: Remove android_library_loader_hook from content API (Closed)

Created:
5 years, 10 months ago by michaelbai
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove android_library_loader_hook from content API As content_jni_onload.h was added, android_library_loader_hook is not needed be a content API, move it to content/app/android/ BUG=447393 Committed: https://crrev.com/236b82b2ab22b3e35c8d1f3ab51f2d2adf860936 Cr-Commit-Position: refs/heads/master@{#316376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -64 lines) Patch
M content/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/child_process_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/content_jni_onload.cc View 2 chunks +1 line, -4 lines 0 comments Download
A + content/app/android/library_loader_hooks.h View 1 chunk +5 lines, -7 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/app/android_library_loader_hooks.h View 1 chunk +0 lines, -28 lines 0 comments Download
M content/shell/android/linker_test_apk/chromium_linker_test_android.cc View 1 chunk +27 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
michaelbai
PTAL
5 years, 10 months ago (2015-02-13 18:07:15 UTC) #2
jam
lgtm
5 years, 10 months ago (2015-02-14 00:26:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914083004/1
5 years, 10 months ago (2015-02-14 01:29:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/35505)
5 years, 10 months ago (2015-02-14 03:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914083004/1
5 years, 10 months ago (2015-02-14 04:22:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 05:13:07 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 05:13:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/236b82b2ab22b3e35c8d1f3ab51f2d2adf860936
Cr-Commit-Position: refs/heads/master@{#316376}

Powered by Google App Engine
This is Rietveld 408576698