Hide Url bar in tab switcher mode.

Hide Url bar in tab switcher mode.

These changes are to make behaviour of chrome shell
similar to chrome by hiding Url bar when tab switcher is shown.

BUG=458042
Committed: https://crrev.com/fa4b126a6ab11dcefa62d660ea57ae8a3b405a91
Cr-Commit-Position: refs/heads/master@{#316202}

[divya.bansal, 2015-02-13 06:28:45]

divya.bansal@samsung.com changed reviewers:
+ bauerb@chromium.org

[divya.bansal, 2015-02-13 06:28:57]

On 2015/02/13 06:28:45, divya.bansal wrote:
> mailto:divya.bansal@samsung.com changed reviewers:
> + mailto:bauerb@chromium.org

@Bernhard PTAL

[Bernhard Bauer, 2015-02-13 09:25:30]

We can now probably also remove the code that hides the keyboard in
TabManager.showTabSwitcher().

https://codereview.chromium.org/914083003/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/914083003/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:261:
* Shows or hides the add and the stop/reload button.
This comment needs to be updated. Maybe we should just rename the whole method
to updateToolbarState().

(BTW, toolbar is a single word, so it shouldn't be CamelCased in the middle.)

[divya.bansal, 2015-02-13 09:31:20]

PTAL

https://codereview.chromium.org/914083003/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/914083003/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:261:
* Shows or hides the add and the stop/reload button.
On 2015/02/13 09:25:30, Bernhard Bauer wrote:
> This comment needs to be updated. Maybe we should just rename the whole method
> to updateToolbarState().
> 
> (BTW, toolbar is a single word, so it shouldn't be CamelCased in the middle.)

Done.

[Bernhard Bauer, 2015-02-13 09:41:25]

Did you compile this code?

Also:

On 2015/02/13 09:25:30, Bernhard Bauer wrote:
> We can now probably also remove the code that hides the keyboard in
> TabManager.showTabSwitcher().

^^^

https://codereview.chromium.org/914083003/diff/20001/chrome/android/shell/jav...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/914083003/diff/20001/chrome/android/shell/jav...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:261:
* Shows or hides the add button, the stop/reload button and the Url bar.
URL is spelled in all uppercase letters.

[divya.bansal, 2015-02-13 09:56:20]

On 2015/02/13 09:41:25, Bernhard Bauer wrote:
> Did you compile this code?
> 
> Also:
> 
> On 2015/02/13 09:25:30, Bernhard Bauer wrote:
> > We can now probably also remove the code that hides the keyboard in
> > TabManager.showTabSwitcher().
> 
> ^^^
> 
>
https://codereview.chromium.org/914083003/diff/20001/chrome/android/shell/jav...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
> (right):
> 
>
https://codereview.chromium.org/914083003/diff/20001/chrome/android/shell/jav...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:261:
> * Shows or hides the add button, the stop/reload button and the Url bar.
> URL is spelled in all uppercase letters.

PTAL

[Bernhard Bauer, 2015-02-13 10:03:51]

Thanks!

https://codereview.chromium.org/914083003/diff/40001/chrome/android/shell/jav...
File chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java
(right):

https://codereview.chromium.org/914083003/diff/40001/chrome/android/shell/jav...
chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java:249:
InputMethodManager mImm = (InputMethodManager) getContext().getSystemService(
And remove this code now.

[divya.bansal, 2015-02-13 10:38:25]

On 2015/02/13 10:03:51, Bernhard Bauer wrote:
> Thanks!
> 
>
https://codereview.chromium.org/914083003/diff/40001/chrome/android/shell/jav...
> File chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java
> (right):
> 
>
https://codereview.chromium.org/914083003/diff/40001/chrome/android/shell/jav...
> chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java:249:
> InputMethodManager mImm = (InputMethodManager) getContext().getSystemService(
> And remove this code now.

PTAL

[Bernhard Bauer, 2015-02-13 10:40:42]

lgtm

[divya.bansal, 2015-02-13 10:41:42]

The CQ bit was checked by divya.bansal@samsung.com

[commit-bot: I haz the power, 2015-02-13 10:41:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914083003/60001

[divya.bansal, 2015-02-13 10:43:39]

On 2015/02/13 10:41:55, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/914083003/60001

@Bernhard Thanks for the review.

[commit-bot: I haz the power, 2015-02-13 11:02:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-13 11:03:42]

Patchset 4 (id:??) landed as
https://crrev.com/fa4b126a6ab11dcefa62d660ea57ae8a3b405a91
Cr-Commit-Position: refs/heads/master@{#316202}