Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 914003004: Add a templated priority queue class. (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : minor #

Patch Set 4 : rework percolateDownIfNecessary #

Patch Set 5 : comments #

Total comments: 8

Patch Set 6 : Address comments #

Patch Set 7 : fix return value #

Patch Set 8 : Reduce number of setIndex calls #

Patch Set 9 : add cast of null to function ptr #

Patch Set 10 : make validate an empty function in release #

Patch Set 11 : Attempt to silence warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -0 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tests.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkTDPQueue.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +191 lines, -0 lines 0 comments Download
A tests/TDPQueueTest.cpp View 1 2 3 4 5 1 chunk +156 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
bsalomon
The idea is to use this to manage the LRU in the cache where only ...
5 years, 10 months ago (2015-02-11 15:44:17 UTC) #2
egdaniel
https://codereview.chromium.org/914003004/diff/80001/src/core/SkTDPQueue.h File src/core/SkTDPQueue.h (right): https://codereview.chromium.org/914003004/diff/80001/src/core/SkTDPQueue.h#newcode35 src/core/SkTDPQueue.h:35: const T& peek() const { return fArray[0]; } we ...
5 years, 10 months ago (2015-02-11 18:58:28 UTC) #3
bsalomon
https://codereview.chromium.org/914003004/diff/80001/src/core/SkTDPQueue.h File src/core/SkTDPQueue.h (right): https://codereview.chromium.org/914003004/diff/80001/src/core/SkTDPQueue.h#newcode35 src/core/SkTDPQueue.h:35: const T& peek() const { return fArray[0]; } On ...
5 years, 10 months ago (2015-02-11 19:14:52 UTC) #4
egdaniel
lgtm
5 years, 10 months ago (2015-02-11 19:49:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914003004/130001
5 years, 10 months ago (2015-02-11 19:51:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/2058) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 10 months ago (2015-02-11 19:52:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914003004/150001
5 years, 10 months ago (2015-02-13 18:49:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/2084)
5 years, 10 months ago (2015-02-13 18:51:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914003004/170001
5 years, 10 months ago (2015-02-13 18:58:35 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2049)
5 years, 10 months ago (2015-02-13 19:01:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914003004/190001
5 years, 10 months ago (2015-02-13 19:02:35 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 19:08:27 UTC) #21
Message was sent while issue was closed.
Committed patchset #11 (id:190001) as
https://skia.googlesource.com/skia/+/3555bd88a6513d219a084eabd41e9dff9e513605

Powered by Google App Engine
This is Rietveld 408576698