Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 914003002: Use ButtonCompat to get Material-y buttons in more places. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, David Trainor- moved to gerrit
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ButtonCompat to get Material-y buttons in more places. ButtonCompat is now used in settings, on the sad tab page, in infobars, and in the website settings popup. Various old button styles can be removed as a happy result of this. This also updates ButtonCompat to style disabled buttons appropriately. Committed: https://crrev.com/3782bc8d618d8f4a3de3592e0a860fab28055521 Cr-Commit-Position: refs/heads/master@{#315709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -233 lines) Patch
D chrome/android/java/res/color/btn_default_preferences.xml View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/android/java/res/drawable/btn_default_preferences.xml View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/java/res/drawable/btn_default_preferences_disabled.xml View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/android/java/res/drawable/btn_default_preferences_enabled.xml View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/android/java/res/drawable/btn_default_preferences_pressed.xml View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/android/java/res/drawable/btn_infobar_blue.xml View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/android/java/res/drawable/sad_tab_reload_button.xml View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/android/java/res/drawable/sad_tab_reload_button_normal.xml View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/android/java/res/drawable/sad_tab_reload_button_pressed.xml View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/android/java/res/layout/infobar_button.xml View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/android/java/res/layout/preference_button.xml View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/android/java/res/layout/sad_tab.xml View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/android/java/res/layout/website_settings.xml View 4 chunks +3 lines, -9 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 2 chunks +1 line, -12 lines 0 comments Download
M chrome/android/java/res/values-v21/dimens.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ButtonCompat.java View 5 chunks +37 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 10 months ago (2015-02-11 01:18:02 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 10 months ago (2015-02-11 01:29:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914003002/1
5 years, 10 months ago (2015-02-11 01:31:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 02:06:19 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 02:06:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3782bc8d618d8f4a3de3592e0a860fab28055521
Cr-Commit-Position: refs/heads/master@{#315709}

Powered by Google App Engine
This is Rietveld 408576698