Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 913993004: Removed the funky 2-stage initialization of PipelineData. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed the funky 2-stage initialization of PipelineData. Use simple old-skool constructors instead. Note that the long repeated member initializer lists could be reduced a bit by using C++11's brace-or-equal initializers, which are actually recommended by the Google C++ style guide in this case, but the ARM toolchain is still buggy in this area (see patch sets 1 and 2). :-/ Committed: https://crrev.com/acd6715dd91c8bf4190ba2c0ccf612d263162dc1 Cr-Commit-Position: refs/heads/master@{#26654}

Patch Set 1 #

Patch Set 2 : Try to make a buggy GCC happy. #

Patch Set 3 : Don't use brace-or-equal-initializers *sigh* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -42 lines) Patch
M src/compiler/pipeline.cc View 1 2 5 chunks +75 lines, -42 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sven Panne
5 years, 10 months ago (2015-02-13 11:06:59 UTC) #2
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-16 09:21:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913993004/40001
5 years, 10 months ago (2015-02-16 09:25:36 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-16 09:30:18 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 09:30:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/acd6715dd91c8bf4190ba2c0ccf612d263162dc1
Cr-Commit-Position: refs/heads/master@{#26654}

Powered by Google App Engine
This is Rietveld 408576698