Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 913943002: Unregister from GCM when the only GCM app is removed (Closed)

Created:
5 years, 10 months ago by jianli
Modified:
5 years, 10 months ago
Reviewers:
fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unregister from GCM when the only GCM app is removed The bug occurred because we remove app handler on extension/app unload. We should not do it at this time since uninstall will trigger unload first. BUG=457433 TEST=tests updated TBR=kalman@chromium.org Committed: https://crrev.com/514b6b0475dd0b15a7a17f020247eaba72841544 Cr-Commit-Position: refs/heads/master@{#315846}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch to land #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M chrome/browser/extensions/extension_gcm_app_handler.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 2 3 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
jianli
5 years, 10 months ago (2015-02-10 22:52:39 UTC) #2
fgorski
lgtm https://codereview.chromium.org/913943002/diff/1/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc File chrome/browser/extensions/extension_gcm_app_handler_unittest.cc (right): https://codereview.chromium.org/913943002/diff/1/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc#newcode151 chrome/browser/extensions/extension_gcm_app_handler_unittest.cc:151: ExtensionGCMAppHandler::OnUnregisterCompleted(app_id,result); nit: space after a comma. (run git ...
5 years, 10 months ago (2015-02-10 23:10:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913943002/20001
5 years, 10 months ago (2015-02-10 23:24:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41852)
5 years, 10 months ago (2015-02-10 23:30:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913943002/20001
5 years, 10 months ago (2015-02-11 00:09:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/31257)
5 years, 10 months ago (2015-02-11 01:26:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913943002/40001
5 years, 10 months ago (2015-02-11 19:00:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/34331)
5 years, 10 months ago (2015-02-11 20:25:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913943002/60001
5 years, 10 months ago (2015-02-11 22:00:35 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-11 22:07:15 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 22:08:53 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/514b6b0475dd0b15a7a17f020247eaba72841544
Cr-Commit-Position: refs/heads/master@{#315846}

Powered by Google App Engine
This is Rietveld 408576698