pkg/analysis_server/lib/src/services/refactoring/extract_method.dart - Issue 913903002: Use async/await in refactorings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

Issue 913903002: Use async/await in refactorings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/inline_local.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

index cb06d569d3dd9ca53fc51cb14018530604f1c910..c222ff0770b3fad95ab5b9ef9e484b6ff68391b7 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_method.dart

@@ -169,14 +169,13 @@ class ExtractMethodRefactoringImpl extends RefactoringImpl implements

}

@override

- Future<RefactoringStatus> checkFinalConditions() {

+ Future<RefactoringStatus> checkFinalConditions() async {

RefactoringStatus result = new RefactoringStatus();

result.addStatus(validateMethodName(name));

result.addStatus(_checkParameterNames());

- return _checkPossibleConflicts().then((status) {

- result.addStatus(status);

- return result;

- });

+ RefactoringStatus status = await _checkPossibleConflicts();

+ result.addStatus(status);

+ return result;

}