build/android/pylib/remote/device/remote_device_test_run.py - Issue 913873003: Fixes DownloadTestResults not actually making results directory if needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/remote/device/remote_device_test_run.py

Issue 913873003: Fixes DownloadTestResults not actually making results directory if needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/remote/device/remote_device_test_run.py

diff --git a/build/android/pylib/remote/device/remote_device_test_run.py b/build/android/pylib/remote/device/remote_device_test_run.py

index 6388bdc53432638d792c59abc531a1f4de9c41ac..43a739949dcb327b9c69c765f4730dbd4b4792cc 100644

--- a/build/android/pylib/remote/device/remote_device_test_run.py

+++ b/build/android/pylib/remote/device/remote_device_test_run.py

@@ -170,8 +170,8 @@ class RemoteDeviceTestRun(test_run.TestRun):

"""

if results_path:

logging.info('Downloading results to %s.' % results_path)

- if not os.path.exists(os.path.basename(results_path)):

- os.makedirs(os.path.basename(results_path))

+ if not os.path.exists(os.path.dirname(results_path)):

+ os.makedirs(os.path.dirname(results_path))

with appurify_sanitized.SanitizeLogging(self._env.verbose_count,

logging.WARNING):

appurify_sanitized.utils.wget(self._results['results']['url'],

« no previous file with comments | « no previous file | no next file » | no next file with comments »