Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 913873003: Fixes DownloadTestResults not actually making results directory if needed. (Closed)

Created:
5 years, 10 months ago by mikecase (-- gone --)
Modified:
5 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes DownloadTestResults not actually making results directory if needed. BUG=452068 Committed: https://crrev.com/9b347ac807205d9c30e46b51c679ba093732bf5b Cr-Commit-Position: refs/heads/master@{#315676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/remote/device/remote_device_test_run.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mikecase (-- gone --)
I'm 90% this is what was actually intended to be written (os.path.dirname vs. os.path.basename). This ...
5 years, 10 months ago (2015-02-10 22:38:34 UTC) #2
jbudorick
lgtm
5 years, 10 months ago (2015-02-10 22:40:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913873003/1
5 years, 10 months ago (2015-02-10 22:41:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 23:40:39 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 23:41:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b347ac807205d9c30e46b51c679ba093732bf5b
Cr-Commit-Position: refs/heads/master@{#315676}

Powered by Google App Engine
This is Rietveld 408576698