Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 913833002: Simplify SkBBH::insert API (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify SkBBH::insert API No one's exploiting the ability to take ownership of the array anymore. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bfd5bff75c0ce27a70f02e4b5578d66aa9d6e306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M bench/RTreeBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBBoxHierarchy.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkRTree.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRTree.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RTreeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 10 months ago (2015-02-10 20:58:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913833002/1
5 years, 10 months ago (2015-02-10 20:59:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-10 20:59:01 UTC) #5
robertphillips
lgtm
5 years, 10 months ago (2015-02-10 21:44:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 21:44:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bfd5bff75c0ce27a70f02e4b5578d66aa9d6e306

Powered by Google App Engine
This is Rietveld 408576698