Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 91383002: Switch V8WindowCustom to the new-style ExceptionState (Closed)

Created:
7 years ago by Mike West
Modified:
7 years ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Switch V8WindowCustom to the new-style ExceptionState BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162978

Patch Set 1 #

Patch Set 2 : Expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M LayoutTests/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-call.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-call-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-frameelement-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-set-window-properties.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-set-window-properties-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-origin-window-open-exception.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-origin-window-open-exception-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/security/postMessage/target-origin-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-method-with-iframe-proto.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Mind taking a look at this 2-day old patch I forgot about? -mike
7 years ago (2013-11-29 10:43:17 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-11-29 10:44:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/91383002/1
7 years ago (2013-11-29 10:48:28 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=4304
7 years ago (2013-11-29 12:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/91383002/20001
7 years ago (2013-12-02 10:38:08 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-02 11:29:32 UTC) #6
Message was sent while issue was closed.
Change committed as 162978

Powered by Google App Engine
This is Rietveld 408576698