Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 913793002: cc: Remove ValidateRenderSurfaces debug check (Closed)

Created:
5 years, 10 months ago by enne (OOO)
Modified:
5 years, 10 months ago
Reviewers:
Ian Vollick
CC:
cc-bugs_chromium.org, chromium-reviews, danakj, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove ValidateRenderSurfaces debug check This function is trying to test when a layer should have a render surface by partially duplicating / reimplementing logic from ShouldHaveRenderSurface. It creates render surfaces, then in the same stack checks to see if a render surface should have been created, but it doesn't use the exact same logic. (This is likely what is causing it to fail.) Rather than trying to make it equal, remove this test, as render surface creation is already well-tested in unit tests. BUG=457217 Committed: https://crrev.com/1e447ad6426b03803cf6cf091ffc8edede265e71 Cr-Commit-Position: refs/heads/master@{#315703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M cc/trees/layer_tree_host_common.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
enne (OOO)
5 years, 10 months ago (2015-02-10 18:47:56 UTC) #2
Ian Vollick
On 2015/02/10 18:47:56, enne wrote: I understand why this check was added, but I agree ...
5 years, 10 months ago (2015-02-11 00:01:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913793002/1
5 years, 10 months ago (2015-02-11 00:02:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 01:33:39 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 01:34:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e447ad6426b03803cf6cf091ffc8edede265e71
Cr-Commit-Position: refs/heads/master@{#315703}

Powered by Google App Engine
This is Rietveld 408576698