Reland "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..."

dart/tests/standalone/io/socket_bind_test.dart

Index: dart/tests/standalone/io/socket_bind_test.dart
diff --git a/dart/tests/standalone/io/socket_bind_test.dart b/dart/tests/standalone/io/socket_bind_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..207ff17eb6952b5ef351a01a1384ef60f32a93e2
--- /dev/null
+++ b/dart/tests/standalone/io/socket_bind_test.dart
@@ -0,0 +1,195 @@
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:async';
+import 'dart:io';
+import 'dart:convert';
+
+import 'package:async_helper/async_helper.dart';
+import 'package:expect/expect.dart';
+
+testBindShared(bool v6Only) {
+  asyncStart();
+  ServerSocket.bind(
+      'localhost', 0, v6Only: v6Only, shared: true).then((socket) {
+    Expect.isTrue(socket.port > 0);
+
+    asyncStart();
+    return ServerSocket.bind(
+        'localhost', socket.port, v6Only: v6Only, shared: true).then((socket2) {
+      Expect.equals(socket.address.address, socket2.address.address);
+      Expect.equals(socket.port, socket2.port);
+      socket.close().whenComplete(asyncEnd);
+      socket2.close().whenComplete(asyncEnd);
+    });
+  });
+}
+
+negTestBindSharedMismatch(bool v6Only) {
+  asyncStart();
+  ServerSocket.bind('localhost', 0, v6Only: v6Only).then((ServerSocket socket) {
+    Expect.isTrue(socket.port > 0);
+
+    asyncStart();
+    return ServerSocket.bind(
+        'localhost', socket.port, v6Only: v6Only).catchError((error) {
+      Expect.isTrue(error is SocketException);
+      Expect.isTrue('$error'.contains('shared flag'));
+      socket.close().whenComplete(asyncEnd);
+      asyncEnd();
+    });
+  });
+}
+
+negTestBindV6OnlyMismatch(bool v6Only) {
+  asyncStart();
+  ServerSocket.bind(
+      'localhost', 0, v6Only: v6Only, shared: true).then((ServerSocket socket) {
+    Expect.isTrue(socket.port > 0);
+
+    asyncStart();
+    return ServerSocket.bind(
+        'localhost', socket.port, v6Only: !v6Only, shared: true)
+        .catchError((error) {
+      Expect.isTrue(error is SocketException);
+      Expect.isTrue('$error'.contains('v6Only flag'));
+      socket.close().whenComplete(asyncEnd);
+      asyncEnd();
+    });
+  });
+}
+
+Future testBindDifferentAddresses(InternetAddress addr1,
+                                  InternetAddress addr2,
+                                  bool addr1V6Only,
+                                  bool addr2V6Only) {
+  asyncStart();
+  return ServerSocket.bind(
+      addr1, 0, v6Only: addr1V6Only, shared: false).then((socket) {
+    Expect.isTrue(socket.port > 0);
+
+    asyncStart();
+    return ServerSocket.bind(
+        addr2, socket.port, v6Only: addr2V6Only, shared: false).then((socket2) {

[kustermann, 2015/02/10 16:35:51]

There's a very small race here -- we assume that the port used by the previous
socket we created is still available for another address (which might not be the
case).

I don't know a good way of making this bullet proof.

[Søren Gjesse, 2015/02/11 08:51:05]

That is probably not possible to be sure unless nothing else is running at the
same time. Retrying 10 times would being the probability further down.

+      Expect.equals(socket.port, socket2.port);
+
+      return Future.wait([
+          socket.close().whenComplete(asyncEnd),
+          socket2.close().whenComplete(asyncEnd),
+      ]);
+    });
+  });
+}
+
+testSocketReferenceInteroperability() {
+  asyncStart();
+    ServerSocket.bind('localhost', 0).then((ServerSocket socket) {
+      Expect.isTrue(socket.port > 0);
+
+      asyncStart();
+      socket.reference.create().then((socket2) {
+        bool gotResponseFrom1;
+        bool gotResponseFrom2;
+
+        Expect.isTrue(socket.port > 0);
+        Expect.equals(socket.port, socket2.port);
+
+        asyncStart();
+        asyncStart();
+        socket.listen((client) {
+          client.drain().whenComplete(asyncEnd);
+          client.write('1: hello world');
+          client.close();
+          socket.close().whenComplete(asyncEnd);
+        }, onDone: asyncEnd);
+
+        asyncStart();
+        asyncStart();
+        socket2.listen((client) {
+          client.drain().whenComplete(asyncEnd);
+          client.write('2: hello world');
+          client.close();
+          socket2.close().whenComplete(asyncEnd);
+        }, onDone: asyncEnd);
+
+        var futures = [];
+        for (int i = 0; i < 2; i++) {
+          asyncStart();
+          futures.add(
+              Socket.connect(socket.address, socket.port).then((Socket socket) {
+            socket.close().whenComplete(asyncEnd);
+            asyncStart();
+            return socket
+                .transform(ASCII.decoder).join('').then((String result) {
+                if (result == '1: hello world') gotResponseFrom1 = true;
+                else if (result == '2: hello world') gotResponseFrom2 = true;
+                else throw 'Unexpected result from server: $result';
+                asyncEnd();
+             });
+          }));
+        }
+        asyncStart();
+        Future.wait(futures).then((_) {
+          Expect.isTrue(gotResponseFrom1);
+          Expect.isTrue(gotResponseFrom2);
+          asyncEnd();
+        });
+      });
+   });
+}
+
+testListenCloseListenClose() async {
+  asyncStart();
+
+  ServerSocket socket =
+      await ServerSocket.bind('localhost', 0, shared: true);
+  ServerSocket socket2 =
+      await ServerSocket.bind('localhost', socket.port, shared: true);
+
+  var subscription = socket.listen((_) { throw 'error'; });
+  subscription.cancel();
+  await socket.close();
+
+  // The second socket should have kept the OS socket alive. We can therefore
+  // test if it is working correctly.
+  asyncStart();
+  socket2.first.then((socket) async {
+    await socket.drain();
+    await socket.close();
+    asyncEnd();
+  });
+
+  Socket client = await Socket.connect('localhost', socket2.port);
+  await client.close();
+  await client.drain();
+
+  asyncEnd();
+}
+
+void main() {
+  testBindShared(false);
+  testBindShared(true);
+
+  negTestBindSharedMismatch(false);
+  negTestBindSharedMismatch(true);
+
+  negTestBindV6OnlyMismatch(true);
+  negTestBindV6OnlyMismatch(false);
+
+  asyncStart();
+  testBindDifferentAddresses(InternetAddress.ANY_IP_V6,
+                             InternetAddress.ANY_IP_V4,
+                             true,
+                             false).then((_) {
+    testBindDifferentAddresses(InternetAddress.ANY_IP_V4,
+                               InternetAddress.ANY_IP_V6,
+                               false,
+                               true);
+    asyncEnd();
+   });
+
+  testSocketReferenceInteroperability();
+
+  testListenCloseListenClose();
+}