Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 913743002: check for nonfinites in rrects (Closed)

Created:
5 years, 10 months ago by reed2
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update test for nonfinites #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M include/core/SkScalar.h View 1 chunk +17 lines, -1 line 0 comments Download
M src/core/SkRRect.cpp View 3 chunks +17 lines, -3 lines 0 comments Download
M tests/PathTest.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
reed1
ptal
5 years, 10 months ago (2015-02-10 16:08:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913743002/1
5 years, 10 months ago (2015-02-10 16:09:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-10 16:09:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1991)
5 years, 10 months ago (2015-02-10 16:14:21 UTC) #7
robertphillips
lgtm
5 years, 10 months ago (2015-02-10 16:19:10 UTC) #8
reed1
5 years, 10 months ago (2015-02-10 16:21:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913743002/20001
5 years, 10 months ago (2015-02-10 16:32:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913743002/20001
5 years, 10 months ago (2015-02-10 16:42:20 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 16:46:27 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/454fa71cc31bf45c14e4c0b25502d5332d76c51c

Powered by Google App Engine
This is Rietveld 408576698