Fix cctest + unittest to work with an external snapshot.

Fix cctest + unittest to work with an external snapshot.

To do so, extract startup_data_util from d8 and use it those executables.

BUG=

Committed: https://crrev.com/2ea8df76baca3a2e6af2b549cac06d58aeac01d7
Cr-Commit-Position: refs/heads/master@{#26547}

[vogelheim, 2015-02-10 15:03:22]

vogelheim@chromium.org changed reviewers:
+ jochen@chromium.org

[vogelheim, 2015-02-10 15:03:33]

https://codereview.chromium.org/913703002/diff/1/test/cctest/cctest.gyp
File test/cctest/cctest.gyp (right):

https://codereview.chromium.org/913703002/diff/1/test/cctest/cctest.gyp#newco...
test/cctest/cctest.gyp:172: '../../src/startup-data-util.cc'
This is a bit ugly... Is there a good place where to put definitions that are
meant to go only into d8 + cctest + unittest?

[jochen (gone - plz use gerrit), 2015-02-10 15:05:56]

lgtm

https://codereview.chromium.org/913703002/diff/1/src/startup-data-util.h
File src/startup-data-util.h (right):

https://codereview.chromium.org/913703002/diff/1/src/startup-data-util.h#newc...
src/startup-data-util.h:1: // Copyright 2014 the V8 project authors. All rights
reserved.
2015

https://codereview.chromium.org/913703002/diff/1/test/cctest/cctest.gyp
File test/cctest/cctest.gyp (right):

https://codereview.chromium.org/913703002/diff/1/test/cctest/cctest.gyp#newco...
test/cctest/cctest.gyp:172: '../../src/startup-data-util.cc'
On 2015/02/10 at 15:03:33, vogelheim wrote:
> This is a bit ugly... Is there a good place where to put definitions that are
meant to go only into d8 + cctest + unittest?

I think it's ok.

An alternative was to add those magically to all targets that produce binaries,
but I think that's actually worse.

[vogelheim, 2015-02-10 15:15:21]

https://codereview.chromium.org/913703002/diff/1/src/startup-data-util.h
File src/startup-data-util.h (right):

https://codereview.chromium.org/913703002/diff/1/src/startup-data-util.h#newc...
src/startup-data-util.h:1: // Copyright 2014 the V8 project authors. All rights
reserved.
On 2015/02/10 15:05:56, jochen (slow) wrote:
> 2015

Done.

[vogelheim, 2015-02-10 15:15:35]

New patchsets have been uploaded after l-g-t-m from jochen@chromium.org

[vogelheim, 2015-02-10 15:16:10]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2015-02-10 15:17:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/913703002/20001

[commit-bot: I haz the power, 2015-02-10 15:38:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-10 15:38:24]

Patchset 2 (id:??) landed as
https://crrev.com/2ea8df76baca3a2e6af2b549cac06d58aeac01d7
Cr-Commit-Position: refs/heads/master@{#26547}