Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 913663002: Fix for Incomplete context menu is shown on pdf files and reload,back,forward options are missing (Closed)

Created:
5 years, 10 months ago by Deepak
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for incomplete context menu in pdf page. when we are viewing the PDF in a MimeHandlerViewGuest then we should use its embedder WebContents. Changes done to use the embedder WebContents if we have guest view. BUG=449919 Committed: https://crrev.com/0c6616522ca22a77e444c4b4f57b3b71baf30cdb Cr-Commit-Position: refs/heads/master@{#316187}

Patch Set 1 #

Patch Set 2 : Fixing error. #

Total comments: 7

Patch Set 3 : Changes as per review comments. #

Total comments: 2

Patch Set 4 : Removing comment. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 2 chunks +7 lines, -16 lines 1 comment Download
M components/renderer_context_menu/render_view_context_menu_base.cc View 1 2 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 21 (5 generated)
Deepak
PTAL at my changes. Thanks
5 years, 10 months ago (2015-02-10 11:32:56 UTC) #2
raymes
https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode765 chrome/browser/renderer_context_menu/render_view_context_menu.cc:765: // Full page plugin, so show page menu items. ...
5 years, 10 months ago (2015-02-11 00:45:39 UTC) #4
Deepak
PTAL https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode765 chrome/browser/renderer_context_menu/render_view_context_menu.cc:765: // Full page plugin, so show page menu ...
5 years, 10 months ago (2015-02-11 05:27:01 UTC) #5
raymes
https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1783 chrome/browser/renderer_context_menu/render_view_context_menu.cc:1783: ->ExecutePluginActionAtLocation(location, action); Ah, I see. Thanks!
5 years, 10 months ago (2015-02-11 23:03:35 UTC) #6
Deepak
On 2015/02/11 23:03:35, raymes wrote: > https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc > File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): > > https://codereview.chromium.org/913663002/diff/20001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode1783 > ...
5 years, 10 months ago (2015-02-12 03:38:07 UTC) #7
raymes
@lazyboy probably isn't a good reviewer. We need to hear back from jam@ or avi@ ...
5 years, 10 months ago (2015-02-12 03:43:02 UTC) #8
Deepak
On 2015/02/12 03:43:02, raymes wrote: > @lazyboy probably isn't a good reviewer. We need to ...
5 years, 10 months ago (2015-02-12 03:50:43 UTC) #10
raymes
Given avi@'s opinion on the bug, I think this looks good and don't have a ...
5 years, 10 months ago (2015-02-13 00:40:27 UTC) #11
Deepak
Thanks for review. PTAL https://codereview.chromium.org/913663002/diff/40001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/913663002/diff/40001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode765 chrome/browser/renderer_context_menu/render_view_context_menu.cc:765: // Full page plugin, so ...
5 years, 10 months ago (2015-02-13 04:31:49 UTC) #13
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-13 05:09:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913663002/60001
5 years, 10 months ago (2015-02-13 06:50:22 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-13 07:44:14 UTC) #17
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0c6616522ca22a77e444c4b4f57b3b71baf30cdb Cr-Commit-Position: refs/heads/master@{#316187}
5 years, 10 months ago (2015-02-13 07:44:43 UTC) #18
raymes
https://codereview.chromium.org/913663002/diff/60001/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (left): https://codereview.chromium.org/913663002/diff/60001/chrome/browser/renderer_context_menu/render_view_context_menu.cc#oldcode778 chrome/browser/renderer_context_menu/render_view_context_menu.cc:778: } I had more of a think about this ...
5 years, 10 months ago (2015-02-16 00:58:41 UTC) #19
raymes
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/935863002/ by raymes@chromium.org. ...
5 years, 10 months ago (2015-02-18 00:43:01 UTC) #20
Deepak
5 years, 6 months ago (2015-06-03 04:47:42 UTC) #21
Message was sent while issue was closed.
On 2015/02/18 00:43:01, raymes wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/935863002/ by mailto:raymes@chromium.org.
> 
> The reason for reverting is: This caused
> http://code.google.com/p/chromium/issues/detail?id=458927 . There is a
followup
> CL: https://codereview.chromium.org/931073002/ which almost does a revert of
> this anyway. So I'm reverting here just to be safe and make sure this doesn't
> make its way to a branch..

https://codereview.chromium.org/931073002/ had been raised for this again.
That fix this issue.

Powered by Google App Engine
This is Rietveld 408576698