Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 913603002: Add Log::VPrint and remove duplicated code. (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Log::VPrint and remove duplicated code. BUG= R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43624

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M runtime/vm/disassembler.cc View 1 chunk +1 line, -10 lines 0 comments Download
M runtime/vm/log.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/log.cc View 1 chunk +23 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 10 months ago (2015-02-09 23:14:03 UTC) #2
srdjan
lgtm
5 years, 10 months ago (2015-02-09 23:28:23 UTC) #3
Cutch
5 years, 10 months ago (2015-02-09 23:28:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698