Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 913573003: Use *cert instead of *cert.get() in ChromeSSLHostStateDelegateTests (Closed)

Created:
5 years, 10 months ago by estark
Modified:
5 years, 10 months ago
Reviewers:
jww, Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also ran 'git cl format' on this file since I was touching a lot of it anyway. Committed: https://crrev.com/2c11cba93784563c827fd4517b2f352f918c7176 Cr-Commit-Position: refs/heads/master@{#316377}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -178 lines) Patch
M chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc View 1 20 chunks +111 lines, -178 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
estark
5 years, 10 months ago (2015-02-09 20:57:51 UTC) #3
Ryan Sleevi
lgtm
5 years, 10 months ago (2015-02-09 21:27:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913573003/1
5 years, 10 months ago (2015-02-09 21:29:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/21860) ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-09 21:33:05 UTC) #10
jww
lgtm
5 years, 10 months ago (2015-02-09 21:33:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913573003/1
5 years, 10 months ago (2015-02-14 04:37:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913573003/20001
5 years, 10 months ago (2015-02-14 04:47:51 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-14 05:40:51 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 05:41:38 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c11cba93784563c827fd4517b2f352f918c7176
Cr-Commit-Position: refs/heads/master@{#316377}

Powered by Google App Engine
This is Rietveld 408576698