Per isolate Log with block support

runtime/vm/isolate.h

Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 765f88b1400ee526b83f718f522efb5c1c30ca44..73646601126a5fd50a805431b98ca31061a15f56 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -52,6 +52,7 @@ class IsolateProfilerData;
 class IsolateSpawnState;
 class InterruptableThreadState;
 class Library;
+class Log;
 class LongJumpScope;
 class MessageHandler;
 class Mutex;
@@ -167,6 +168,7 @@ class Isolate : public BaseIsolate {
   }
 
   const char* name() const { return name_; }
+  class Log* Log() const;

[koda, 2015/02/09 17:57:29]

Why not "log" (and avoid the "class")? The collision with the class name is a
bit confusing.

[Cutch, 2015/02/09 18:19:39]

Per our style guide- lower case log() must be a straight return of the field.
Alternatively I could use GetLog.

 
   int64_t start_time() const { return start_time_; }
 
@@ -693,6 +695,10 @@ class Isolate : public BaseIsolate {
   intptr_t defer_finalization_count_;
   DeoptContext* deopt_context_;
 
+  // Log.
+  bool service_isolate_;

[srdjan, 2015/02/09 18:01:02]

I think 'is_service_isolate_' is more descriptive.

[Cutch, 2015/02/09 18:19:39]

Done.

+  class Log* log_;
+
   // Status support.
   char* stacktrace_;
   intptr_t stack_frame_index_;
@@ -769,6 +775,8 @@ class Isolate : public BaseIsolate {
 REUSABLE_HANDLE_LIST(REUSABLE_FRIEND_DECLARATION)
 #undef REUSABLE_FRIEND_DECLARATION
 
+  friend class Service;
+
   DISALLOW_COPY_AND_ASSIGN(Isolate);
 };