Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 913503002: cull edges that are to the right of the clip (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

cull edges that are to the right of the clip BUG=skia: Committed: https://skia.googlesource.com/skia/+/31223e0cb74f47f63b094520a9830c525b72fe87

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M src/core/SkEdgeBuilder.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkEdgeClipper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkEdgeClipper.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkLineClipper.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkLineClipper.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M src/core/SkScan_Path.cpp View 3 chunks +6 lines, -4 lines 1 comment Download
M tests/ClipperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913503002/1
5 years, 10 months ago (2015-02-09 16:00:45 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-09 16:00:46 UTC) #3
reed1
The interesting change is in SkScan_Path.cpp
5 years, 10 months ago (2015-02-09 16:03:06 UTC) #6
caryclark
lgtm https://codereview.chromium.org/913503002/diff/1/src/core/SkScan_Path.cpp File src/core/SkScan_Path.cpp (right): https://codereview.chromium.org/913503002/diff/1/src/core/SkScan_Path.cpp#newcode443 src/core/SkScan_Path.cpp:443: if (0 == count) { I don't mind ...
5 years, 10 months ago (2015-02-09 16:06:30 UTC) #7
reed1
On 2015/02/09 16:06:30, caryclark wrote: > lgtm > > https://codereview.chromium.org/913503002/diff/1/src/core/SkScan_Path.cpp > File src/core/SkScan_Path.cpp (right): > ...
5 years, 10 months ago (2015-02-09 16:08:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913503002/1
5 years, 10 months ago (2015-02-09 16:32:57 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:33:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/31223e0cb74f47f63b094520a9830c525b72fe87

Powered by Google App Engine
This is Rietveld 408576698