msvs: Prefer x64 toolset if we are running on 64-bit

msvs: Prefer x64 toolset if we are running on 64-bit

The ninja generator also does the equivalent of this.  This is for the pure msvs generator.

BUG=
R=scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=2032

[Shezan Baig (Bloomberg), 2015-02-09 15:57:31]

sbaig1@bloomberg.net changed reviewers:
+ scottmg@chromium.org

[Shezan Baig (Bloomberg), 2015-02-09 15:57:32]

Not sure how to test this, other than grepping the generated vcxproj file for
this attribute.  Is it worth a test?

[scottmg, 2015-02-10 18:48:46]

On 2015/02/09 15:57:32, Shezan Baig (Bloomberg) wrote:
> Not sure how to test this, other than grepping the generated vcxproj file for
> this attribute.  Is it worth a test?

Will this cause problems on Express (vs. Community) or before 2013 (when there
was no amd64_x86)?

I don't think a grep test is worth bothering with.

[Shezan Baig (Bloomberg), 2015-02-10 18:56:27]

On 2015/02/10 18:48:46, scottmg (ooo mon feb 9th) wrote:
> On 2015/02/09 15:57:32, Shezan Baig (Bloomberg) wrote:
> > Not sure how to test this, other than grepping the generated vcxproj file
for
> > this attribute.  Is it worth a test?
> 
> Will this cause problems on Express (vs. Community) or before 2013 (when there
> was no amd64_x86)?
> 
> I don't think a grep test is worth bothering with.


I don't have an install of Express or Community to test with, but I do have
VS2010 installed.  I tried this with -Gmsvs_version=2010 and it looks like it
doesn't cause any problems (looks like it just ignores this attribute).

[scottmg, 2015-02-10 19:18:13]

On 2015/02/10 18:56:27, Shezan Baig (Bloomberg) wrote:
> On 2015/02/10 18:48:46, scottmg (ooo mon feb 9th) wrote:
> > On 2015/02/09 15:57:32, Shezan Baig (Bloomberg) wrote:
> > > Not sure how to test this, other than grepping the generated vcxproj file
> for
> > > this attribute.  Is it worth a test?
> > 
> > Will this cause problems on Express (vs. Community) or before 2013 (when
there
> > was no amd64_x86)?
> > 
> > I don't think a grep test is worth bothering with.
> 
> 
> I don't have an install of Express or Community to test with, but I do have
> VS2010 installed.  I tried this with -Gmsvs_version=2010 and it looks like it
> doesn't cause any problems (looks like it just ignores this attribute).

OK, lgtm then. (Hopefully we don't have a lot of active pre-2013 users at this
point anyway, and we don't have bots in any case. Maybe someone will pipe up if
it causes problems.)

[Shezan Baig (Bloomberg), 2015-02-10 19:25:10]

Committed patchset #1 (id:1) manually as 2032 (presubmit successful).