Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 913473002: Testing a fix to crbug.com/456059. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
sof
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Script moving fixes related to context documents. There were 2 bugs: 1) Moving script element to a new document whose context document is the same as the current document: we ended up doing ScriptRunner::movePendingAsyncScript to itself and that does the wrong thing (just removes the script). 2) Moving script element to a new document which is not its own context document, and then moving it somewhere else. The script was not where we expected it to be (it was in the context document, we expected it to be in the non-context document). BUG=456059 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189886

Patch Set 1 #

Patch Set 2 : better fix + tests #

Patch Set 3 : oops #

Patch Set 4 : oops #

Total comments: 1

Patch Set 5 : refactored #

Messages

Total messages: 9 (4 generated)
marja
sigbjornf, ptal
5 years, 10 months ago (2015-02-09 16:47:07 UTC) #2
sof
Makes sense to be consulting the context document on the "source" side when moving; the ...
5 years, 10 months ago (2015-02-10 09:47:49 UTC) #4
sof
lgtm
5 years, 10 months ago (2015-02-10 10:26:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913473002/80001
5 years, 10 months ago (2015-02-10 10:28:32 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 11:36:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189886

Powered by Google App Engine
This is Rietveld 408576698