Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 913463002: Reduce the number of iterations in some OSR tests by using an explicit %OptimizeOsr(). (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce the number of iterations in some OSR tests by using an explicit %OptimizeOsr(). R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/1db760de7d75be720d0b98e0bed0acf55f0aec4a Cr-Commit-Position: refs/heads/master@{#26540}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -109 lines) Patch
M test/mjsunit/compiler/osr-alignment.js View 2 chunks +10 lines, -7 lines 0 comments Download
M test/mjsunit/compiler/osr-nested2.js View 2 chunks +6 lines, -5 lines 0 comments Download
M test/mjsunit/compiler/osr-nested3.js View 2 chunks +6 lines, -5 lines 0 comments Download
M test/mjsunit/compiler/osr-simple.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/regress/regress-1145.js View 1 1 chunk +0 lines, -54 lines 1 comment Download
M test/mjsunit/regress/regress-3032.js View 1 chunk +3 lines, -1 line 0 comments Download
D test/mjsunit/regress/regress-634.js View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
titzer
5 years, 10 months ago (2015-02-09 14:01:42 UTC) #1
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-09 14:04:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913463002/1
5 years, 10 months ago (2015-02-09 14:06:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2794)
5 years, 10 months ago (2015-02-09 14:20:58 UTC) #6
titzer
https://codereview.chromium.org/913463002/diff/20001/test/mjsunit/regress/regress-1145.js File test/mjsunit/regress/regress-1145.js (left): https://codereview.chromium.org/913463002/diff/20001/test/mjsunit/regress/regress-1145.js#oldcode34 test/mjsunit/regress/regress-1145.js:34: As discussed in person, this test essentially enforces language ...
5 years, 10 months ago (2015-02-10 09:32:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913463002/20001
5 years, 10 months ago (2015-02-10 09:33:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-10 09:53:15 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 09:53:41 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1db760de7d75be720d0b98e0bed0acf55f0aec4a
Cr-Commit-Position: refs/heads/master@{#26540}

Powered by Google App Engine
This is Rietveld 408576698