content/common/media/video_capture_messages.h - Issue 91343002: Added supported formats caching to VideoCaptureManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/video_capture_messages.h

Issue 91343002: Added supported formats caching to VideoCaptureManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/video_capture_manager_unittest.cc ('K') | « content/browser/renderer_host/media/video_capture_manager_unittest.cc ('k') | media/video/capture/android/video_capture_device_android.cc » ('j') | media/video/capture/fake_video_capture_device.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/media/video_capture_messages.h

diff --git a/content/common/media/video_capture_messages.h b/content/common/media/video_capture_messages.h

index 30ac62c4766e6fcb58a065a4cc5b83e5a70e3e22..55cbb38496dc5c374148060c02c9e0ec1ca3ef9b 100644

--- a/content/common/media/video_capture_messages.h

+++ b/content/common/media/video_capture_messages.h

@@ -20,10 +20,6 @@ IPC_STRUCT_TRAITS_BEGIN(media::VideoCaptureParams)

IPC_STRUCT_TRAITS_MEMBER(allow_resolution_change)

IPC_STRUCT_TRAITS_END()

-IPC_STRUCT_TRAITS_BEGIN(media::VideoCaptureCapability)

perkj_chrome 2013/11/27 17:53:12 I am a bit confused. Have you added IPC_STRUCT_TRA

mcasas 2013/12/03 14:28:41 sheu@ added it during the review, diff can be seen

- IPC_STRUCT_TRAITS_MEMBER(supported_format)

-IPC_STRUCT_TRAITS_END()

// TODO(nick): device_id in these messages is basically just a route_id. We

// should shift to IPC_MESSAGE_ROUTED and use MessageRouter in the filter impls.