Added supported formats caching to VideoCaptureManager.

media/video/capture/fake_video_capture_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of a fake VideoCaptureDevice class. Used for testing other
 // video capture classes when no real hardware is available.
 
 #ifndef MEDIA_VIDEO_CAPTURE_FAKE_VIDEO_CAPTURE_DEVICE_H_
 #define MEDIA_VIDEO_CAPTURE_FAKE_VIDEO_CAPTURE_DEVICE_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/thread.h"
 #include "media/video/capture/video_capture_device.h"
 
 namespace media {
 
 class MEDIA_EXPORT FakeVideoCaptureDevice : public VideoCaptureDevice {
  public:
   static VideoCaptureDevice* Create(const Name& device_name);
   virtual ~FakeVideoCaptureDevice();
   // Used for testing. This will make sure the next call to Create will
   // return NULL;
   static void SetFailNextCreate();
+  static void SetNumberOfFakeDevices(int num);
+  static int NumberOfFakeDevices();

[perkj_chrome, 2013/11/27 17:53:12]

Fyi- I am trying to do the same thing in
https://codereview.chromium.org/88283002

[mcasas, 2013/12/03 14:28:41]

First one wins! :)
Kidding: I'll rebase against you.

 
   static void GetDeviceNames(Names* device_names);
   static void GetDeviceSupportedFormats(const Name& device,
-                                        VideoCaptureCapabilities* formats);
+                                        VideoCaptureFormats* supported_formats);
 
   // VideoCaptureDevice implementation.
   virtual void AllocateAndStart(const VideoCaptureParams& params,
                                 scoped_ptr<VideoCaptureDevice::Client> client)
       OVERRIDE;
   virtual void StopAndDeAllocate() OVERRIDE;
 
  private:
   // Flag indicating the internal state.
   enum InternalState {
     kIdle,
     kCapturing,
     kError
   };
   FakeVideoCaptureDevice();
 
   // Called on the capture_thread_.
   void OnCaptureTask();
-
-  // EXPERIMENTAL, similar to allocate, but changes resolution and calls

[perkj_chrome, 2013/11/27 17:53:12]

And this - is this intentional? 

[mcasas, 2013/12/03 14:28:41]

Well, this code is not experimental anymore (I added this
comment). Besides, the OnFrameInfoChanged is deprecated.

-  // client->OnFrameInfoChanged(VideoCaptureCapability&)
   void Reallocate();
   void PopulateFormatRoster();
 
   scoped_ptr<VideoCaptureDevice::Client> client_;
   InternalState state_;
   base::Thread capture_thread_;
   scoped_ptr<uint8[]> fake_frame_;
   int frame_count_;
   VideoCaptureFormat capture_format_;
 
   // When the device is configured as mutating video captures, this vector
   // holds the available ones which are used in sequence, restarting at the end.
   std::vector<VideoCaptureFormat> format_roster_;
   int format_roster_index_;
 
+  static int number_of_fake_devices_;

[perkj_chrome, 2013/11/27 17:53:12]

atomic32 if you touch this from several threads like I do in the cl mentioned
above.

[mcasas, 2013/12/03 14:28:41]

If you only have one setter and multiple getters, is there
a race?

   static bool fail_next_create_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeVideoCaptureDevice);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_FAKE_VIDEO_CAPTURE_DEVICE_H_