Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: cc/blink/web_display_item_list_impl.h

Issue 913413005: Constify SkPicture in DrawingDisplayItem (cc side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile issue. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/blink/web_display_item_list_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/blink/web_display_item_list_impl.h
diff --git a/cc/blink/web_display_item_list_impl.h b/cc/blink/web_display_item_list_impl.h
index cd35975caeb5ae531bf631108b993ab6a674aa41..dee4ad452b516d542c7855c3da485ff2c5b84eff 100644
--- a/cc/blink/web_display_item_list_impl.h
+++ b/cc/blink/web_display_item_list_impl.h
@@ -14,6 +14,7 @@
#include "third_party/WebKit/public/platform/WebFloatPoint.h"
#include "third_party/WebKit/public/platform/WebVector.h"
#include "third_party/skia/include/core/SkRegion.h"
+#include "ui/gfx/geometry/point_f.h"
class SkImageFilter;
class SkMatrix44;
@@ -31,8 +32,12 @@ class WebDisplayItemListImpl : public blink::WebDisplayItemList {
scoped_refptr<cc::DisplayItemList> ToDisplayItemList();
// blink::WebDisplayItemList implementation.
- virtual void appendDrawingItem(SkPicture* picture,
- const blink::WebFloatPoint& location);
+ virtual void appendDrawingItem(
+ const SkPicture*,
+ const blink::WebFloatPoint& location = gfx::PointF());
+ virtual void appendDrawingItem(
+ SkPicture*,
+ const blink::WebFloatPoint& location = gfx::PointF());
ajuma 2015/02/12 19:42:59 I think we can do without the default arguments he
Stephen Chennney 2015/02/12 19:47:59 Yes, I'll verify.
virtual void appendClipItem(
const blink::WebRect& clip_rect,
const blink::WebVector<SkRRect>& rounded_clip_rects);
« no previous file with comments | « no previous file | cc/blink/web_display_item_list_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698