Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 913413004: Expose SkPathRef::unique through SkPath. (Closed)

Created:
5 years, 10 months ago by djsollen
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Expose SkPathRef::unique through SkPath. This allows for the removal of SkPath::mSourcePath on Android as they now have a better indicator of whether or not the path can be used again via the Java API. Committed: https://skia.googlesource.com/skia/+/90b5c0ced0e7ecc8812509d4c6c8017b1d08308f

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment and define #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/core/SkPath.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
djsollen
do you want this wrapped in the android-only ifdef?
5 years, 10 months ago (2015-02-12 19:31:09 UTC) #2
reed1
this still seems a little funny, since its a copy-on-write dude, but lgtm w/ nit ...
5 years, 10 months ago (2015-02-12 19:47:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913413004/20001
5 years, 10 months ago (2015-02-12 20:00:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 20:08:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/90b5c0ced0e7ecc8812509d4c6c8017b1d08308f

Powered by Google App Engine
This is Rietveld 408576698