Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 913413002: DatabaseManager::terminateDatabaseThread should handle multiple DatabaseContexts. (Closed)

Created:
5 years, 10 months ago by tkent
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DatabaseManager::terminateDatabaseThread should handle multiple DatabaseContexts. This is a followup of Blink r190021 [1]. [1] http://src.chromium.org/viewvc/blink?view=rev&rev=190021 BUG=455368, 455789 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190035

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove isEmpty check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/modules/webdatabase/DatabaseManager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
I remembered we can have multiple active Documents in a single process.
5 years, 10 months ago (2015-02-12 07:25:30 UTC) #2
haraken
LGTM https://codereview.chromium.org/913413002/diff/1/Source/modules/webdatabase/DatabaseManager.cpp File Source/modules/webdatabase/DatabaseManager.cpp (right): https://codereview.chromium.org/913413002/diff/1/Source/modules/webdatabase/DatabaseManager.cpp#newcode60 Source/modules/webdatabase/DatabaseManager.cpp:60: if (!s_databaseManager || s_databaseManager->m_contextMap.isEmpty()) Now you won't need ...
5 years, 10 months ago (2015-02-12 08:36:54 UTC) #3
tkent
https://codereview.chromium.org/913413002/diff/1/Source/modules/webdatabase/DatabaseManager.cpp File Source/modules/webdatabase/DatabaseManager.cpp (right): https://codereview.chromium.org/913413002/diff/1/Source/modules/webdatabase/DatabaseManager.cpp#newcode60 Source/modules/webdatabase/DatabaseManager.cpp:60: if (!s_databaseManager || s_databaseManager->m_contextMap.isEmpty()) On 2015/02/12 08:36:53, haraken wrote: ...
5 years, 10 months ago (2015-02-12 08:39:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913413002/20001
5 years, 10 months ago (2015-02-12 08:40:59 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 09:54:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190035

Powered by Google App Engine
This is Rietveld 408576698