Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 913393004: Revert of cc: Make PaintedScrollbarLayer not use ContentsScalingLayer (Closed)

Created:
5 years, 10 months ago by enne (OOO)
Modified:
5 years, 10 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews, vmpstr, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Make PaintedScrollbarLayer not use ContentsScalingLayer (patchset #4 id:60001 of https://codereview.chromium.org/913133004/) Reason for revert: Causes DCHECKs in layout tests. Original issue's description: > cc: Make PaintedScrollbarLayer not use ContentsScalingLayer > > ContentsScalingLayer depends on the main thread running calculate draw > properties and updating contents scale and content bounds. In order to > switch to using property trees (which don't currently calculate these > values), PaintedScrollbarLayer needs to calculate contents scale > internally. > > This also moves towards removing ContentsScalingLayer (currently also > used by TiledLayer and HeadsUpDisplayLayer), which once it's gone will > allow contents scale and content bounds to removed entirely from Layer > and LayerImpl. > > Committed: https://crrev.com/a499bbb66f29815ae0cef3eaa62ee2b3d3526d04 > Cr-Commit-Position: refs/heads/master@{#316088} TBR=danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8e7bf2757ee8f82a7d2bd5a50c68812db3398420 Cr-Commit-Position: refs/heads/master@{#316089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -281 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.h View 5 chunks +8 lines, -14 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 9 chunks +26 lines, -45 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 4 chunks +30 lines, -23 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl_unittest.cc View 4 chunks +0 lines, -16 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 3 chunks +37 lines, -16 lines 0 comments Download
M cc/layers/scrollbar_layer_impl_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 26 chunks +166 lines, -126 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_painted_scrollbar_layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_test_common.cc View 1 chunk +1 line, -9 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
enne (OOO)
Created Revert of cc: Make PaintedScrollbarLayer not use ContentsScalingLayer
5 years, 10 months ago (2015-02-12 23:55:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913393004/1
5 years, 10 months ago (2015-02-12 23:56:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 23:58:09 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 23:59:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e7bf2757ee8f82a7d2bd5a50c68812db3398420
Cr-Commit-Position: refs/heads/master@{#316089}

Powered by Google App Engine
This is Rietveld 408576698