Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 913383002: X87: new classes: implement correct check for uninitialized this in 'super()' (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: new classes: implement correct check for uninitialized this in 'super()' port fdcf3e59ba4af1aa3c5b31a18e615169c97958ab (r26599) original commit message: new classes: implement correct check for uninitialized this in 'super()' BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/71784ec03c7a7bca004ea1a7b70ee1ec25d24c0f Cr-Commit-Position: refs/heads/master@{#26603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-12 08:05:08 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-12 08:07:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913383002/1
5 years, 10 months ago (2015-02-12 08:07:59 UTC) #5
chunyang.dai
Committed patchset #1 (id:1) manually as 71784ec03c7a7bca004ea1a7b70ee1ec25d24c0f (presubmit successful).
5 years, 10 months ago (2015-02-12 08:11:54 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 08:11:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71784ec03c7a7bca004ea1a7b70ee1ec25d24c0f
Cr-Commit-Position: refs/heads/master@{#26603}

Powered by Google App Engine
This is Rietveld 408576698