Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: build/config/android/config.gni

Issue 913373002: Update Chomium's build files to work w/ latest GN binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn_cpu_arch_changes
Patch Set: cleanup / review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/config.gni
diff --git a/build/config/android/config.gni b/build/config/android/config.gni
index c6202d4e98a1bdd26ea053f441830c9fbf6dc95f..02a486ff1a0c94896f96880e6af45f782d90ae45 100644
--- a/build/config/android/config.gni
+++ b/build/config/android/config.gni
@@ -45,9 +45,9 @@ if (is_android) {
# Defines the name the Android build gives to the current host CPU
# architecture, which is different than the names GN uses.
- if (build_cpu_arch == "x64") {
+ if (host_cpu == "x64") {
android_host_arch = "x86_64"
- } else if (build_cpu_arch == "x86") {
+ } else if (host_cpu == "x86") {
android_host_arch = "x86"
} else {
assert(false, "Need Android toolchain support for your build CPU arch.")
@@ -55,7 +55,7 @@ if (is_android) {
# Defines the name the Android build gives to the current host CPU
# architecture, which is different than the names GN uses.
- if (build_os == "linux") {
+ if (host_os == "linux") {
android_host_os = "linux"
} else {
assert(false, "Need Android toolchain support for your build OS.")
@@ -104,17 +104,17 @@ if (is_android) {
# Location of libgcc. This is only needed for the current GN toolchain, so we
# only need to define the current one, rather than one for every platform
# like the toolchain roots.
- if (cpu_arch == "x86") {
+ if (current_cpu == "x86") {
android_prebuilt_arch = "android-x86"
_binary_prefix = "i686-linux-android"
android_toolchain_root = "$x86_android_toolchain_root"
android_libgcc_file = "$android_toolchain_root/lib/gcc/i686-linux-android/${_android_toolchain_version}/libgcc.a"
- } else if (cpu_arch == "arm") {
+ } else if (current_cpu == "arm") {
android_prebuilt_arch = "android-arm"
_binary_prefix = "arm-linux-androideabi"
android_toolchain_root = "$arm_android_toolchain_root"
android_libgcc_file = "$android_toolchain_root/lib/gcc/arm-linux-androideabi/${_android_toolchain_version}/libgcc.a"
- } else if (cpu_arch == "mipsel") {
+ } else if (current_cpu == "mipsel") {
android_prebuilt_arch = "android-mips"
_binary_prefix = "mipsel-linux-android"
android_toolchain_root = "$mips_android_toolchain_root"
@@ -131,19 +131,19 @@ if (is_android) {
# ABI ------------------------------------------------------------------------
- if (cpu_arch == "x86") {
+ if (current_cpu == "x86") {
android_app_abi = "x86"
- } else if (cpu_arch == "arm") {
+ } else if (current_cpu == "arm") {
import("//build/config/arm.gni")
if (arm_version < 7) {
android_app_abi = "armeabi"
} else {
android_app_abi = "armeabi-v7a"
}
- } else if (cpu_arch == "mipsel") {
+ } else if (current_cpu == "mipsel") {
android_app_abi = "mips"
} else {
- assert(false, "Unknown Android ABI: " + cpu_arch)
+ assert(false, "Unknown Android ABI: " + current_cpu)
}
} else {
if (!defined(is_android_webview_build)) {
« no previous file with comments | « build/config/allocator.gni ('k') | build/config/arm.gni » ('j') | ppapi/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698