third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js - Issue 913353002: Update paper-checkbox to 0.5.4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js

Issue 913353002: Update paper-checkbox to 0.5.4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Applying sed to remove cr's. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/polymer/components-chromium/paper-checkbox/paper-checkbox.html ('k') | third_party/polymer/components/paper-checkbox/.bower.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js

diff --git a/third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js b/third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js

index 55f75ba227c2f79188dc87da32131d88f901ccde..553257268baf9bce8da6a516fcb2aee8f37c4e5f 100644

--- a/third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js

+++ b/third_party/polymer/components-chromium/paper-checkbox/paper-checkbox-extracted.js

@@ -17,19 +17,15 @@

toggles: true,

checkedChanged: function() {

- var cl = this.$.checkbox.classList;

- cl.toggle('checked', this.checked);

- cl.toggle('unchecked', !this.checked);

- cl.toggle('checkmark', !this.checked);

- cl.toggle('box', this.checked);

+ this.$.checkbox.classList.toggle('checked', this.checked);

this.setAttribute('aria-checked', this.checked ? 'true': 'false');

+ this.$.checkmark.classList.toggle('hidden', !this.checked);

this.fire('core-change');

checkboxAnimationEnd: function() {

- var cl = this.$.checkbox.classList;

- cl.toggle('checkmark', this.checked && !cl.contains('checkmark'));

- cl.toggle('box', !this.checked && !cl.contains('box'));

+ var cl = this.$.checkmark.classList;

+ cl.toggle('hidden', !this.checked && cl.contains('hidden'));

}

});